Dear SY, Linux kernel upstream 上面對於這種 ifdef 的方式是不認同的 能否用其他的方式來代替呢? 或是利用變數來控制。
另外如果default是跑哪邊，某一路只是for special case的話 可以先把其中一邊拿掉。 先上upstream 之後再來refine Best Regards, Tony -----Original Message----- From: Kalle Valo [mailto:[email protected]] Sent: Thursday, April 20, 2017 6:54 PM To: Larry Finger Cc: [email protected]; 莊彥宣; Pkshih; Birming Chiu; Shaofu; Steven Ting Subject: Re: [PATCH 06/10] rtlwifi: btcoex: 21a 2ant: run mechanism if status changes or auto adjust is set Larry Finger <[email protected]> writes: > From: Yan-Hsuan Chuang <[email protected]> > > The driver will periodically ask the coex, and the coex only runs the > mechanism when the status was changed or the auto adjust is set. > > Signed-off-by: Yan-Hsuan Chuang <[email protected]> > Signed-off-by: Larry Finger <[email protected]> > Cc: Pkshih <[email protected]> > Cc: Birming Chiu <[email protected]> > Cc: Shaofu <[email protected]> > Cc: Steven Ting <[email protected]> [...] > @@ -4200,7 +4200,14 @@ void ex_btc8821a2ant_periodical(struct btc_coexist > *btcoexist) > "[BTCoex], > ****************************************************************\n"); > } > > +#ifdef BT_AUTO_REPORT_ONLY_8821A_2ANT > btc8821a2ant_query_bt_info(btcoexist); > +#else > btc8821a2ant_monitor_bt_ctr(btcoexist); > btc8821a2ant_monitor_wifi_ctr(btcoexist); > + > + if (btc8821a2ant_is_wifi_status_changed(btcoexist) || > + coex_dm->auto_tdma_adjust) > + btc8821a2ant_run_coexist_mechanism(btcoexist); > +#endif This ifdef looks fishy. Why is it needed? In general I would expect to see ifdefs only for Kconfig options or defines which value comes from core kernel. -- Kalle Valo ------Please consider the environment before printing this e-mail.
