Joe Perches <[email protected]> writes: > On Fri, 2017-05-12 at 15:20 +0000, Kalle Valo wrote: >> Kalle Valo <[email protected]> writes: >> Here's the diff between v5 and v6: > > trivia: > >> diff --git a/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c >> b/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c > [] >> @@ -93,9 +94,11 @@ qtnf_change_virtual_intf(struct wiphy *wiphy, >> >> qtnf_scan_done(vif->mac, true); >> >> - if (qtnf_cmd_send_change_intf_type(vif, type, mac_addr)) { >> - pr_err("failed to change interface type\n"); >> - return -EFAULT; >> + ret = qtnf_cmd_send_change_intf_type(vif, type, mac_addr); >> + if (ret) { >> + pr_err("VIF%u.%u: failed to change VIF type: %d\n", >> + vif->mac->macid, vif->vifid, ret); > > It might make sense to add vif_<level> macros or functions > to make sure the vif->mac->macid, vif->vifid are emitted > consistently and simplify the calls > > For instance: > vif_err(vif, "failed to change VIF type %d\n", ret); > > etc...
Yeah, I was thinking the same. > Not necessarily in this patch, maybe in a future one. Exactly, that's easy to do in a separate patch after the driver is merged. -- Kalle Valo
