Arend van Spriel <[email protected]> writes: > Since commit 9cc4b7cb86cb ("brcmfmac: Make skb header writable > before use") the headroom usage has been fixed. However, the > driver was keeping statistics that got lost. So reworking the > code so we get those driver statistics back for debugging. > > Cc: James Hughes <[email protected]> > Reviewed-by: Hante Meuleman <[email protected]> > Reviewed-by: Pieter-Paul Giesberts <[email protected]> > Reviewed-by: Franky Lin <[email protected]> > Signed-off-by: Arend van Spriel <[email protected]> > --- > .../net/wireless/broadcom/brcm80211/brcmfmac/bus.h | 15 ++++++++++++-- > .../wireless/broadcom/brcm80211/brcmfmac/core.c | 23 > +++++++++++++++------- > .../wireless/broadcom/brcm80211/brcmfmac/sdio.c | 13 +++++++----- > 3 files changed, 37 insertions(+), 14 deletions(-) > > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bus.h > b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bus.h > index e1a4d9e..163ddc4 100644 > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bus.h > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bus.h > @@ -113,6 +113,17 @@ struct brcmf_bus_msgbuf { > > > /** > + * struct brcmf_bus_stats - bus statistic counters. > + * > + * @pktcowed: packets cowed for extra headroom/unorphan. > + * @pktcow_failed: packets dropped due to failed cow-ing. > + */ > +struct brcmf_bus_stats { > + atomic_t pktcowed; > + atomic_t pktcow_failed; > +};
Same question as in the previous patch. I only see updates for these variables, but nobody reading them? -- Kalle Valo
