From: Sharon Dvir <[email protected]>

The sta_id variable is used as an index in an array, should be unsigned.
Found by Klocwork.

Fixes: 9f9af3d7d303 ("iwlwifi: mvm: re-aggregate shared queue after unsharing")
Signed-off-by: Sharon Dvir <[email protected]>
Signed-off-by: Luca Coelho <[email protected]>
---
 drivers/net/wireless/intel/iwlwifi/mvm/sta.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/sta.c 
b/drivers/net/wireless/intel/iwlwifi/mvm/sta.c
index 02f35a929606..9ec427966533 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/sta.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/sta.c
@@ -398,7 +398,7 @@ static int iwl_mvm_get_queue_agg_tids(struct iwl_mvm *mvm, 
int queue)
        struct iwl_mvm_sta *mvmsta;
        unsigned long tid_bitmap;
        unsigned long agg_tids = 0;
-       s8 sta_id;
+       u8 sta_id;
        int tid;
 
        lockdep_assert_held(&mvm->mutex);
@@ -989,7 +989,7 @@ static void iwl_mvm_unshare_queue(struct iwl_mvm *mvm, int 
queue)
 {
        struct ieee80211_sta *sta;
        struct iwl_mvm_sta *mvmsta;
-       s8 sta_id;
+       u8 sta_id;
        int tid = -1;
        unsigned long tid_bitmap;
        unsigned int wdg_timeout;
-- 
2.11.0

Reply via email to