Sergey Matyukevich <[email protected]> writes: > On Tue, Jun 27, 2017 at 08:27:37PM +0300, Kalle Valo wrote: >> >> External Email >> >> >> Sergey Matyukevich <[email protected]> writes: >> >> > Userspace tools may hang on scan in the case when scan completion event >> > is not returned by firmware. This patch implements the scan timeout >> > to avoid such situation. >> > >> > Signed-off-by: Sergey Matyukevich <[email protected]> >> >> [...] >> >> > +static __always_inline void qtnf_wmac_lock(struct qtnf_wmac *mac) >> > +{ >> > + mutex_lock(&mac->mac_lock); >> > +} >> > + >> > +static __always_inline void qtnf_wmac_unlock(struct qtnf_wmac *mac) >> > +{ >> > + mutex_unlock(&mac->mac_lock); >> > +} >> >> Why? These look pointless to me. > > Could you please clarify a bit. You mean, locking/unlocking directly instead > of > using inline wrappers ?
Yeah, these kind of simple locking wrappers should not be used. They only add confusion. -- Kalle Valo
