On 7/26/2017 10:25 PM, Ian Molton wrote:
This function needs to be split up into separate read / write variants
Reviewed-by: Arend van Spriel <arend.vanspr...@broadcom.com>
Signed-off-by: Ian Molton <i...@mnementh.co.uk>
more comments below...
.../wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 69 +++++++++++++++-------
1 file changed, 47 insertions(+), 22 deletions(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c
index 9d5716d0ad73..858ad2d8706b 100644
@@ -706,10 +725,10 @@ int brcmf_sdiod_send_buf(struct brcmf_sdio_dev *sdiodev,
u8 *buf, uint nbytes)
err = brcmf_sdiod_addrprep(sdiodev, &addr);
- err = brcmf_sdiod_buffrw(sdiodev, SDIO_FUNC_2, true, addr,
+ err = brcmf_sdiod_buff_write(sdiodev, SDIO_FUNC_2, addr, mypkt);
You are keen on sprinkling whitespace here and there. Could you please
use separate patches for that as much as possible. Not sure why you
added this one...
...and kept this one.