On Tue, Aug 15, 2017 at 12:40 AM, Arend van Spriel <[email protected]> wrote: > On 14-08-17 08:53, Prameela Rani Garnepudi wrote: >> >> Hi Kalle, >> >> I will change the debug level and send the updated patches again. >> >> Thanks, >> Prameela > > > Please do not top-post.
Yeah, thanks. I will take care of this for all my replies from now on wards. > >> On Mon, Aug 14, 2017 at 10:24 AM, Kalle Valo <[email protected]> wrote: >>> >>> Amitkumar Karwar <[email protected]> writes: >>> >>>> From: Prameela Rani Garnepudi <[email protected]> >>>> >>>> Station structures are maintained in driver with required >>>> fields. When mac80211 callback sta_add is called, driver >>>> iterates through list of connected stations to check available >>>> index and assigns station id which is important for further >>>> communication to that station. Then peer notify frame is send >>>> to firmware to inform the firmware about new station connection. >>>> >>>> Signed-off-by: Prameela Rani Garnepudi <[email protected]> >>>> Signed-off-by: Amitkumar Karwar <[email protected]> >>> >>> >>> [...] >>> >>>> @@ -1157,18 +1159,81 @@ static int rsi_mac80211_sta_add(struct >>>> ieee80211_hw *hw, >>>> { >>>> struct rsi_hw *adapter = hw->priv; >>>> struct rsi_common *common = adapter->priv; >>>> + bool sta_exist = false; >>>> + struct rsi_sta *rsta; >>>> + >>>> + print_hex_dump(KERN_INFO, "Station add: ", DUMP_PREFIX_OFFSET, >>>> + 16, 1, sta->addr, ETH_ALEN, 0); >>> >>> >>> The driver should not spam the logs every time a client connects, so >>> this should be a debug message. > > > I am wondering why print_hex_dump() is used for printing the station mac > address. Just use: pr_debug("Station add: %pM\n", sta->addr); Yeah. Got the point, thanks. I will use 'rsi' macro 'rsi_dbg' for this debug message with this format specifier '%pM'. > > Regards, > Arend -- G. Prameela Rani (M.Tech,CSE)
