On Mon, 2017-08-21 at 15:32 +0200, Toke Høiland-Jørgensen wrote:
> 
> > +                   struct ieee80211_vif *vif;
> >                     struct ieee80211_key_conf *hw_key;
> >                     u32 flags;
> > -                   /* 4 bytes free */
> > +                   codel_time_t enqueue_time;
> 
> A side effect of this is that enqueue_time will be valid in the
> driver; which is good as far as I'm concerned (I've been thinking
> about using it to make decisions about when to stop retrying a
> frame).

Well, I think we need to do a lot more to allow that, but I guess
ultimately it would be possible - though we have this as codel_time_t
so the driver doesn't really know the reference etc. immediately.

> If we want to save the four bytes, is there any reason we can't just
> change the codel code to use skb->tstamp instead?

I didn't really want to go into that.

Any comments on the patch itself? I don't think I even merged this yet.

johannes

Reply via email to