Hi Dan,
> This is a semi-automatic email about new static checker warnings.
>
> The patch 531682159092: "mac80211: fix VLAN handling with TXQs" from
> Jun 22, 2017, leads to the following Smatch complaint:
>
> net/mac80211/tx.c:3529 ieee80211_tx_dequeue()
> error: we previously assumed 'skb' could be null (see line 3511)
Thanks for the report.
> net/mac80211/tx.c
> 3500 tx.key, skb);
> 3501 } else {
> 3502 if (invoke_tx_handlers_late(&tx))
> 3503 goto begin;
> 3504
> 3505 skb = __skb_dequeue(&tx.skbs);
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> The NULL skb would have to come from here.
Yeah - this can't actually be empty at this point, as far as I can
tell.
> 3511 if (skb && skb_has_frag_list(skb) &&
> ^^^
> Old code checks
So I guess this is just useless.
I can send a patch to remove this if the warning bothers you much, or
I'll defer until I get smatch updated and it starts bothering me ;-)
johannes
