On Tue, Nov 21, 2017 at 03:24:03PM +0800, Xinming Hu wrote: > Firmware do not support change interface from micro-ap mode to > station mode, forbidden this operation in driver accordingly.
All firmware or specific versions? > > Signed-off-by: Cathy Luo <[email protected]> > Signed-off-by: Xinming Hu <[email protected]> > --- > drivers/net/wireless/marvell/mwifiex/cfg80211.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c > b/drivers/net/wireless/marvell/mwifiex/cfg80211.c > index 6e0d9a9..a87758f 100644 > --- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c > +++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c > @@ -1181,6 +1181,12 @@ static int mwifiex_deinit_priv_params(struct > mwifiex_private *priv) > switch (type) { > case NL80211_IFTYPE_ADHOC: > case NL80211_IFTYPE_STATION: > + if (mwifiex_get_priv_by_id(priv->adapter, priv->bss_num, > + MWIFIEX_BSS_TYPE_STA)){ Is this test necessary? dev->ieee80211_ptr->iftype is always NL80211_IFTYPE_AP at this point. > + mwifiex_dbg(priv->adapter, INFO, > + "Skip change virtual interface\n"); Is this message easy to understand? Other messages in the same function seem easier; e.g. "%s: changing to %d not supported\n" > + return 0; Should this be -EOPNOTSUPP rather than 0? > + } > return mwifiex_change_vif_to_sta_adhoc(dev, curr_iftype, > type, params); > break; > -- > 1.9.1 > -- James Cameron http://quozl.netrek.org/
