On Sat 2017-12-09 21:13:38, Johannes Berg wrote:
> From: Johannes Berg <[email protected]>
> 
> Due to overlap between
> commit 1281103770e9 ("mac80211: Simplify locking in 
> ieee80211_sta_tear_down_BA_sessions()")
> and the way that Luca modified
> commit 72e2c3438ba3 ("mac80211: tear down RX aggregations first")
> when sending it upstream from Intel's internal tree, we get
> the following warning:
> 
> WARNING: CPU: 0 PID: 5472 at net/mac80211/agg-tx.c:315 
> ___ieee80211_stop_tx_ba_session+0x158/0x1f0
> 
> since there's no appropriate locking around the call to
> ___ieee80211_stop_tx_ba_session; Sara's original just had
> a call to the locked __ieee80211_stop_tx_ba_session (one
> less underscore) but it looks like Luca modified both of
> the calls when fixing it up for upstream, leading to the
> problem at hand.
> 
> Move the locking appropriately to fix this problem.
> 
> Reported-by: Kalle Valo <[email protected]>
> Reported-by: Pavel Machek <[email protected]>
> Signed-off-by: Johannes Berg <[email protected]>

Tested-by: Pavel Machek <[email protected]>

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) 
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: Digital signature

Reply via email to