Am 30.01.2018 um 08:56 schrieb Johannes Berg:
> On Mon, 2018-01-22 at 18:04 +0100, Benjamin Beichler wrote:
>> + if(!info)
>> + pr_debug("mac80211_hwsim: radio index %d already
>> present\n",
>> + idx);
> Can this really trigger? I think I'll edit it out - we do pass
> info==NULL in the case of module init, but in that case nothing else
> can interfere and we can't even really fail.
It should not be triggered because of already existing macs, I added it
for somehow completeness, but you can leave it out.After having again a look on it, there could be an -ENOMEM on rhashtable_insert. Maybe it's better to explicitly catch only -EEXIST and print for the rest an generic error. Do you agree ? > johannes > -- M.Sc. Benjamin Beichler Universität Rostock, Fakultät für Informatik und Elektrotechnik Institut für Angewandte Mikroelektronik und Datentechnik University of Rostock, Department of CS and EE Institute of Applied Microelectronics and CE Richard-Wagner-Straße 31 18119 Rostock Deutschland/Germany phone: +49 (0) 381 498 - 7278 email: [email protected] www: http://www.imd.uni-rostock.de/
smime.p7s
Description: S/MIME Cryptographic Signature
