Amitkumar Karwar <[email protected]> writes:

> From: Prameela Rani Garnepudi <[email protected]>
>
> Rx bluetooth endpoint shall be added in further patches. Rx control
> block is introduced here to handle Rx packets properly. Separate
> function is written to initialize the RX control blocks.
>
> Signed-off-by: Prameela Rani Garnepudi <[email protected]>
> Signed-off-by: Siva Rebbagondla <[email protected]>
> Signed-off-by: Amitkumar Karwar <[email protected]>

[...]

> +static int rsi_usb_init_rx(struct rsi_hw *adapter)
> +{
> +     struct rsi_91x_usbdev *dev = (struct rsi_91x_usbdev *)adapter->rsi_dev;
> +     struct rx_usb_ctrl_block *rx_cb;
> +     u8 idx;
> +
> +     for (idx = 0; idx < MAX_RX_URBS; idx++) {
> +             rx_cb = &dev->rx_cb[idx];
> +
> +             rx_cb->rx_buffer = kzalloc(RSI_USB_BUF_SIZE * 2,
> +                                        GFP_KERNEL | GFP_DMA);

Do you really need GFP_DMA? From the documentation:

 "GFP_DMA exists for historical reasons and should be avoided where
  possible."

-- 
Kalle Valo

Reply via email to