> -----Message d'origine----- > De : Johannes Berg [mailto:[email protected]] > Envoyé : lundi 19 février 2018 13:35 > À : Jean Pierre TOSONI; [email protected] > Objet : Re: [PATCH] mac80211: inform wireless layer when frame RSSI > is invalid > (...) > > > /* Track average RSSI from the Beacon frames of the current AP > */ > > + if (rx_status->flag & RX_FLAG_NO_SIGNAL_VAL) > > + goto skip_signal_processing; > > if (ifmgd->flags & IEEE80211_STA_RESET_SIGNAL_AVE) { > > ifmgd->flags &= ~IEEE80211_STA_RESET_SIGNAL_AVE; > > ewma_beacon_signal_init(&ifmgd->ave_beacon_signal); > > @@ -3454,6 +3456,7 @@ static void ieee80211_rx_mgmt_beacon(struct > ieee80211_sub_if_data *sdata, > > sig, GFP_KERNEL); > > } > > } > > +skip_signal_processing: > > Can't say I like this - how about we pull out the actual processing > into a helper function, and then abort that function early if the > NO_SIGNAL_VAL flag is set. >
Since I am working on an older version of mac80211, I was aiming to keep changes minimal to avoid breaking something I could not test... I'll have a look to your suggestion. > johannes
