On 3/16/2018 4:41 PM, Takashi Iwai wrote:
The brcms_ucode_init_buf() duplicates the ucode chunks via kmemdup()
with GFP_ATOMIC as a precondition of wl->lock acquired.  This caused
allocation failures sometimes as reported in the bugzilla below.

When looking at the the real usage, one can find that it's called
solely from brcms_request_fw(), and it's obviously outside the lock.
Hence we can use GFP_KERNEL there safely for avoiding such allocation
errors.

Bugzilla: http://bugzilla.suse.com/show_bug.cgi?id=1085174

Acked-by: Arend van Spriel <arend.vanspr...@broadcom.com>
Signed-off-by: Takashi Iwai <ti...@suse.de>

---
  drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)


Reply via email to