Hi Ben, Thank you for the patch! Yet something to improve:
[auto build test ERROR on v4.16-rc4] [cannot apply to next-20180319] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Ben-Caradoc-Davies/mac80211-add-ieee80211_hw-flag-for-QoS-NDP-support/20180319-170624 config: i386-randconfig-s1-201811 (attached as .config) compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): >> net/mac80211/debugfs.c:174:18: error: >> 'IEEE80211_HW_SUPPORTS_SUPPORTS_QOS_NDP' undeclared here (not in a function) #define FLAG(F) [IEEE80211_HW_##F] = #F ^ net/mac80211/debugfs.c:215:2: note: in expansion of macro 'FLAG' FLAG(SUPPORTS_SUPPORTS_QOS_NDP), ^~~~ net/mac80211/debugfs.c:174:18: error: array index in initializer not of integer type #define FLAG(F) [IEEE80211_HW_##F] = #F ^ net/mac80211/debugfs.c:215:2: note: in expansion of macro 'FLAG' FLAG(SUPPORTS_SUPPORTS_QOS_NDP), ^~~~ net/mac80211/debugfs.c:174:18: note: (near initialization for 'hw_flag_names') #define FLAG(F) [IEEE80211_HW_##F] = #F ^ net/mac80211/debugfs.c:215:2: note: in expansion of macro 'FLAG' FLAG(SUPPORTS_SUPPORTS_QOS_NDP), ^~~~ vim +/IEEE80211_HW_SUPPORTS_SUPPORTS_QOS_NDP +174 net/mac80211/debugfs.c 827b1fb4 Johannes Berg 2009-03-13 172 68920c97 Andrey Ryabinin 2016-01-20 173 static const char *hw_flag_names[] = { 30686bf7 Johannes Berg 2015-06-02 @174 #define FLAG(F) [IEEE80211_HW_##F] = #F 30686bf7 Johannes Berg 2015-06-02 175 FLAG(HAS_RATE_CONTROL), 30686bf7 Johannes Berg 2015-06-02 176 FLAG(RX_INCLUDES_FCS), 30686bf7 Johannes Berg 2015-06-02 177 FLAG(HOST_BROADCAST_PS_BUFFERING), 30686bf7 Johannes Berg 2015-06-02 178 FLAG(SIGNAL_UNSPEC), 30686bf7 Johannes Berg 2015-06-02 179 FLAG(SIGNAL_DBM), 30686bf7 Johannes Berg 2015-06-02 180 FLAG(NEED_DTIM_BEFORE_ASSOC), 30686bf7 Johannes Berg 2015-06-02 181 FLAG(SPECTRUM_MGMT), 30686bf7 Johannes Berg 2015-06-02 182 FLAG(AMPDU_AGGREGATION), 30686bf7 Johannes Berg 2015-06-02 183 FLAG(SUPPORTS_PS), 30686bf7 Johannes Berg 2015-06-02 184 FLAG(PS_NULLFUNC_STACK), 30686bf7 Johannes Berg 2015-06-02 185 FLAG(SUPPORTS_DYNAMIC_PS), 30686bf7 Johannes Berg 2015-06-02 186 FLAG(MFP_CAPABLE), 30686bf7 Johannes Berg 2015-06-02 187 FLAG(WANT_MONITOR_VIF), 30686bf7 Johannes Berg 2015-06-02 188 FLAG(NO_AUTO_VIF), 30686bf7 Johannes Berg 2015-06-02 189 FLAG(SW_CRYPTO_CONTROL), 30686bf7 Johannes Berg 2015-06-02 190 FLAG(SUPPORT_FAST_XMIT), 30686bf7 Johannes Berg 2015-06-02 191 FLAG(REPORTS_TX_ACK_STATUS), 30686bf7 Johannes Berg 2015-06-02 192 FLAG(CONNECTION_MONITOR), 30686bf7 Johannes Berg 2015-06-02 193 FLAG(QUEUE_CONTROL), 30686bf7 Johannes Berg 2015-06-02 194 FLAG(SUPPORTS_PER_STA_GTK), 30686bf7 Johannes Berg 2015-06-02 195 FLAG(AP_LINK_PS), 30686bf7 Johannes Berg 2015-06-02 196 FLAG(TX_AMPDU_SETUP_IN_HW), 30686bf7 Johannes Berg 2015-06-02 197 FLAG(SUPPORTS_RC_TABLE), 30686bf7 Johannes Berg 2015-06-02 198 FLAG(P2P_DEV_ADDR_FOR_INTF), 30686bf7 Johannes Berg 2015-06-02 199 FLAG(TIMING_BEACON_ONLY), 30686bf7 Johannes Berg 2015-06-02 200 FLAG(SUPPORTS_HT_CCK_RATES), 30686bf7 Johannes Berg 2015-06-02 201 FLAG(CHANCTX_STA_CSA), 30686bf7 Johannes Berg 2015-06-02 202 FLAG(SUPPORTS_CLONED_SKBS), 30686bf7 Johannes Berg 2015-06-02 203 FLAG(SINGLE_SCAN_ON_ALL_BANDS), b98fb44f Arik Nemtsov 2015-06-10 204 FLAG(TDLS_WIDER_BW), 99e7ca44 Emmanuel Grumbach 2015-08-15 205 FLAG(SUPPORTS_AMSDU_IN_AMPDU), 35afa588 Helmut Schaa 2015-09-09 206 FLAG(BEACON_TX_STATUS), 31104891 Johannes Berg 2015-10-22 207 FLAG(NEEDS_UNIQUE_STA_ADDR), 412a6d80 Sara Sharon 2015-12-08 208 FLAG(SUPPORTS_REORDERING_BUFFER), c9c5962b Johannes Berg 2016-03-31 209 FLAG(USES_RSS), 6e0456b5 Felix Fietkau 2016-03-03 210 FLAG(TX_AMSDU), 6e0456b5 Felix Fietkau 2016-03-03 211 FLAG(TX_FRAG_LIST), e8a24cd4 Rajkumar Manoharan 2016-09-14 212 FLAG(REPORTS_LOW_ACK), f3fe4e93 Sara Sharon 2016-10-18 213 FLAG(SUPPORTS_TX_FRAG), e2fb1b83 Yingying Tang 2017-10-24 214 FLAG(SUPPORTS_TDLS_BUFFER_STA), b9b085d9 Ben Caradoc-Davies 2018-03-19 215 FLAG(SUPPORTS_SUPPORTS_QOS_NDP), 30686bf7 Johannes Berg 2015-06-02 216 #undef FLAG 30686bf7 Johannes Berg 2015-06-02 217 }; 30686bf7 Johannes Berg 2015-06-02 218 :::::: The code at line 174 was first introduced by commit :::::: 30686bf7f5b3c30831761e188a6e3cb33580fa48 mac80211: convert HW flags to unsigned long bitmap :::::: TO: Johannes Berg <[email protected]> :::::: CC: Johannes Berg <[email protected]> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
