On Mon, 2018-02-19 at 18:02 +0100, Toke Høiland-Jørgensen wrote: > This adds support for exporting the mac80211 TXQ stats via nl80211 by > way of a nested TXQ stats attribute, as well as for configuring the > quantum and limits that were previously only changeable through debugfs.
So I finally (sorry) decided to apply this, but I get a few issues with it (aside from trivial rebase issues). If you're not able to fix them now let me know and I can: 1) Lots of places put the sinfo on the stack, but it's now way bigger, so we get warnings like net/mac80211/ethtool.c: In function ‘ieee80211_get_stats’: net/mac80211/ethtool.c:204:1: warning: the frame size of 1752 bytes is larger than 1024 bytes [-Wframe-larger-than=] net/mac80211/ethtool.c:74 ieee80211_get_stats() warn: 'sinfo' puts 1672 bytes on stack I guess we need to pull those out to dynamic allocations. net/mac80211/cfg.c:3762:12: warning: context imbalance in 'ieee80211_get_txq_stats' - different lock contexts for basic block net/mac80211/tx.c: In function ‘ieee80211_txq_set_params’: net/mac80211/tx.c:1478:1: warning: control reaches end of non-void function [-Wreturn-type] also show up. johannes
