Sergey Matyukevich <[email protected]> writes: > Hello Toke and all, > >> Since the addition of the TXQ stats to cfg80211, the station_info struct >> has grown to be quite large, which results in warnings when allocated on >> the stack. Fix the affected places to do dynamic allocations instead. >> >> Fixes: 52539ca89f36 ("cfg80211: Expose TXQ stats and parameters to >> userspace") >> Signed-off-by: Toke Høiland-Jørgensen <[email protected]> >> --- >> drivers/net/wireless/ath/ath6kl/main.c | 14 ++++++---- >> drivers/net/wireless/ath/wil6210/debugfs.c | 22 ++++++++++----- >> drivers/net/wireless/ath/wil6210/wmi.c | 19 ++++++++----- >> .../broadcom/brcm80211/brcmfmac/cfg80211.c | 18 ++++++++---- >> drivers/net/wireless/marvell/mwifiex/uap_event.c | 25 +++++++++++------ >> drivers/net/wireless/quantenna/qtnfmac/event.c | 29 >> +++++++++++++------- >> 6 files changed, 82 insertions(+), 45 deletions(-) > > Thanks for taking care of this. As for qtnfmac part, there are two > more EINVALs returned during payload processing. So they should be > modified as well to avoid memleaks. Here is a fixup on top of your > patch:
Ah yes, so there is; guess I missed those. Thanks for noticing! I'll fold in your changes and resend :) -Toke
