From: Dedy Lansky <[email protected]>

For negative temperatures, "temp" debugfs is showing wrong values.
Use signed types so proper calculations is done for sub zero
temperatures.

Signed-off-by: Dedy Lansky <[email protected]>
Signed-off-by: Maya Erez <[email protected]>
---
 drivers/net/wireless/ath/wil6210/debugfs.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/ath/wil6210/debugfs.c 
b/drivers/net/wireless/ath/wil6210/debugfs.c
index 5d1e48d..4356b32 100644
--- a/drivers/net/wireless/ath/wil6210/debugfs.c
+++ b/drivers/net/wireless/ath/wil6210/debugfs.c
@@ -1388,7 +1388,7 @@ static int wil_bf_seq_open(struct inode *inode, struct 
file *file)
 };
 
 /*---------temp------------*/
-static void print_temp(struct seq_file *s, const char *prefix, u32 t)
+static void print_temp(struct seq_file *s, const char *prefix, s32 t)
 {
        switch (t) {
        case 0:
@@ -1396,7 +1396,8 @@ static void print_temp(struct seq_file *s, const char 
*prefix, u32 t)
                seq_printf(s, "%s N/A\n", prefix);
        break;
        default:
-               seq_printf(s, "%s %d.%03d\n", prefix, t / 1000, t % 1000);
+               seq_printf(s, "%s %s%d.%03d\n", prefix, (t < 0 ? "-" : ""),
+                          abs(t / 1000), abs(t % 1000));
                break;
        }
 }
@@ -1404,7 +1405,7 @@ static void print_temp(struct seq_file *s, const char 
*prefix, u32 t)
 static int wil_temp_debugfs_show(struct seq_file *s, void *data)
 {
        struct wil6210_priv *wil = s->private;
-       u32 t_m, t_r;
+       s32 t_m, t_r;
        int rc = wmi_get_temperature(wil, &t_m, &t_r);
 
        if (rc) {
-- 
1.9.1

Reply via email to