On Fri, 2018-08-10 at 12:55 +0200, Stanislaw Gruszka wrote:
> According to kconfig-language.txt conditional dependency should be
> expressed 2 times:
> 
>         bool "foo" if BAR
>         default y if BAR
> 
> Indeed, without additional if expression we always build with
> CFG80211_REQUIRE_SIGNED_REGDB even when CFG80211_CERTIFICATION_ONUS
> is not set.

That's the intent. If you do set CERTIFICATION_ONUS, then you can
disable this (presumably because you have external OS image verification
mechanisms, or similar).

If you don't set CERTIFICATION_ONUS, this should always be set.

Perhaps it should be renamed to CFG80211_REQUIRE_REGDB_SIGNATURE or so,
which might be clearer? And a case has been made before for adding
CFG80211_FIRMWARE_REGDB_SUPPORT that controls the whole feature, but
this patch is clearly wrong.

johannes


Reply via email to