On Fri, 2018-08-17 at 20:35 -0700, Nye Liu wrote: > The TX_STATUS_FAIL_DEST_PS case fills logs with full backtraces, which > are pretty useless. Just do IWL_ERR() printk. > > Signed-off-by: Nye Liu <[email protected]> > --- > drivers/net/wireless/intel/iwlwifi/mvm/tx.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/tx.c > b/drivers/net/wireless/intel/iwlwifi/mvm/tx.c > index cf2591f2ac23..87044953e6b4 100644 > --- a/drivers/net/wireless/intel/iwlwifi/mvm/tx.c > +++ b/drivers/net/wireless/intel/iwlwifi/mvm/tx.c > @@ -1407,8 +1407,10 @@ static void iwl_mvm_rx_tx_cmd_single(struct iwl_mvm > *mvm, > /* the FW should have stopped the queue and not > * return this status > */ > - WARN_ON(1); > info->flags |= IEEE80211_TX_STAT_TX_FILTERED; > + IWL_ERR(mvm, "TX_STATUS_FAIL_DEST_PS: " > + "tid %d, status %x, flags %x\n", tid, status, > + info->flags); > break; > default: > break;
I think this error is serious enough and we would like to catch it when it occurs so we can debug the actual cause. But I agree that we shouldn't be repeating it millions of times. What about just changing it to WARN_ON_ONCE() instead? -- Cheers, Luca.
