Luca Coelho <[email protected]> writes: > On Thu, 2018-08-23 at 14:13 +0300, Kalle Valo wrote: >> Luca Coelho <[email protected]> writes: >> >> > > > - * You should have received a copy of the GNU General Public >> > > > License along with >> > > > - * this program; if not, write to the Free Software >> > > > Foundation, >> > > > Inc., >> > > > - * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA >> > > > - * >> > > > * The full GNU General Public License is included in this >> > > > distribution in the >> > > > * file called LICENSE. >> > > > * >> > > >> > > Ok, you have more of these removals in this patch so I guess it's >> > > intentional. But IMHO it would be nicer to remove these all in >> > > one go >> > > instead of sprinkle around in different patches. >> > >> > IMHO it's too much fuzz for mostly useless warning removal... We >> > need >> > to update the copyright when this hits, so we just do it at the >> > same >> > time. >> > >> > But you're the boss, I can submit a patch to remove just that, all >> > at >> > once. >> >> Yeah, please do that. It shouldn't take more than few minutes anyway. >> >> The thing is that then you are reviewing a big patchset and all of >> sudden see a license text changes without no mention in the commit >> log, >> it takes extra time to check it. Sure, with one patch it doens't >> matter >> but then you are going through 20+ patches (or even more) it makes a >> difference. So it's a lot easier for me to change all license text in >> one go. > > Okay. I'll send one patch on top of all these ones I sent already, > okay?
Yeah, no need to change existing patches. So sounds good, thanks! -- Kalle Valo
