Johannes Berg <johan...@sipsolutions.net> writes: > From: Johannes Berg <johannes.b...@intel.com> > > Some frames may have a non-zero skb->priority assigned by > mac80211 internally, e.g. TDLS setup frames, regardless of > support for QoS. > > Currently, we set skb->priority to 0 for all data frames. > Note that there's a comment that this is "required for > correct WPA/11i MIC", but that doesn't seem true as we use > > if (ieee80211_is_data_qos(hdr->frame_control)) > qos_tid = ieee80211_get_tid(hdr); > else > qos_tid = 0; > > in the code there. We could therefore reconsider this, but > it seems like unnecessary complexity for the unlikely (and > not very useful) case of not having QoS on the connection. > > This situation then causes something strange - most data > frames will go on TXQ for TID 0 for non-QoS connections, > but very few exceptions that are internally generated will > go on another TXQ, possibly causing confusion.
What kind of confusion are you seeing? Reordering issues, or something else? -Toke
