On 2018-09-16 10:42, Toke Høiland-Jørgensen wrote:
+/**
+ * ieee80211_return_txq - return a TXQ previously acquired by
ieee80211_next_txq()
+ *
+ * @hw: pointer as obtained from ieee80211_alloc_hw()
+ * @txq: pointer obtained from station or virtual interface
+ *
+ * Should only be called between calls to
ieee80211_txq_schedule_start()
+ * and ieee80211_txq_schedule_end().
+ */
+void ieee80211_return_txq(struct ieee80211_hw *hw, struct
ieee80211_txq *txq);
+
return_txq() should return a bool to inform the driver that whether txq
is
queued back or not. Otherwise the same txq will be served indefinitely
until txq becomes empty. This problem occurs when the driver is running
out
of hw descriptors or driver sends only N frames (< backlog_packets).
Also an option to add the node at head or tail would be preferred. If
return_txq
adds node at head of list, then it is forcing the driver to serve same
txq until it
becomes empty. Also this will not allow the driver to send N frames from
each txqs.
+/**
+ * ieee80211_txq_schedule_start - acquire locks for safe scheduling of
an AC
+ *
+ * @hw: pointer as obtained from ieee80211_alloc_hw()
+ * @ac: AC number to acquire locks for
+ *
+ * Acquire locks needed to schedule TXQs from the given AC. Should be
called
+ * before ieee80211_next_txq() or ieee80211_schedule_txq().
+ */
Typo error. s/schedule_txq()/return_txq()/.
-Rajkumar
