Hi Dan, whoops, right ... thank you!
Will do in a v2, at least if this patch is wanted. :)
Thank you!
Simon
On Thursday, September 20, 2018 12:20:14 PM CEST Dan Carpenter wrote:
> Hi Simon,
>
> I love your patch! Perhaps something to improve:
>
> url:
> https://github.com/0day-ci/linux/commits/Simon-Wunderlich/mac80211-allow-sc
> ans-on-radar-channels-unless-there-is-CAC-or-CSA/20180919-071924 base:
> https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211.git master
>
> New smatch warnings:
> net/mac80211/scan.c:508 ieee80211_can_scan() warn: signedness bug returning
> '(-16)'
>
> Old smatch warnings:
> net/mac80211/scan.c:511 ieee80211_can_scan() warn: signedness bug returning
> '(-16)'
>
> #
> https://github.com/0day-ci/linux/commit/ad9617f275c425ddf25eb83678062ab87d4
> c0870 git remote add linux-review https://github.com/0day-ci/linux
> git remote update linux-review
> git checkout ad9617f275c425ddf25eb83678062ab87d4c0870
> vim +508 net/mac80211/scan.c
>
> f3b85252 Johannes Berg 2009-04-23 503
> 133d40f9 Stanislaw Gruszka 2012-03-28 504 static bool
> ieee80211_can_scan(struct ieee80211_local *local, ^^^^
> 133d40f9 Stanislaw Gruszka 2012-03-28 505 struct
> ieee80211_sub_if_data *sdata) 133d40f9 Stanislaw Gruszka 2012-03-28 506 {
> ad9617f2 Simon Wunderlich 2018-09-18 507 if (sdata->wdev.cac_started)
> ad9617f2 Simon Wunderlich 2018-09-18 @508 return -EBUSY;
> ^^^^^^^^^^^^^
> ad9617f2 Simon Wunderlich 2018-09-18 509
> ad9617f2 Simon Wunderlich 2018-09-18 510 if (sdata->vif.csa_active)
> ad9617f2 Simon Wunderlich 2018-09-18 511 return -EBUSY;
> ^^^^^^^^^^^^^^
> 164eb02d Simon Wunderlich 2013-02-08 512
> 2eb278e0 Johannes Berg 2012-06-05 513 if
> (!list_empty(&local->roc_list)) 133d40f9 Stanislaw Gruszka 2012-03-28 514
> return false;
> 133d40f9 Stanislaw Gruszka 2012-03-28 515
> 133d40f9 Stanislaw Gruszka 2012-03-28 516 if (sdata->vif.type ==
> NL80211_IFTYPE_STATION && 392b9ffb Stanislaw Gruszka 2013-08-27 517
>
> sdata->u.mgd.flags & IEEE80211_STA_CONNECTION_POLL) 133d40f9 Stanislaw
> Gruszka 2012-03-28 518 return false;
> 133d40f9 Stanislaw Gruszka 2012-03-28 519
> 133d40f9 Stanislaw Gruszka 2012-03-28 520 return true;
> 133d40f9 Stanislaw Gruszka 2012-03-28 521 }
> 133d40f9 Stanislaw Gruszka 2012-03-28 522
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology
> Center https://lists.01.org/pipermail/kbuild-all Intel
> Corporation
signature.asc
Description: This is a digitally signed message part.
