Hi Yan-Hsuan, Thank you for the patch! Yet something to improve:
[auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on v4.19-rc4 next-20180921] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/yhchuang-realtek-com/rtwlan-mac80211-driver-for-Realtek-802-11ac-wireless-network-chips/20180923-065459 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master config: openrisc-allmodconfig (attached as .config) compiler: or1k-linux-gcc (GCC) 6.0.0 20160327 (experimental) reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=openrisc All errors (new ones prefixed by >>): drivers/net//wireless/realtek/rtwlan/pci.c: In function 'rtw_pci_parse_configuration': >> drivers/net//wireless/realtek/rtwlan/pci.c:1009:2: error: implicit >> declaration of function 'pcie_capability_read_word' >> [-Werror=implicit-function-declaration] pcie_capability_read_word(pdev, PCI_EXP_LNKCTL, &link_control); ^~~~~~~~~~~~~~~~~~~~~~~~~ drivers/net//wireless/realtek/rtwlan/pci.c: In function 'rtw_pci_declaim': >> drivers/net//wireless/realtek/rtwlan/pci.c:1037:2: error: implicit >> declaration of function 'pci_clear_master' >> [-Werror=implicit-function-declaration] pci_clear_master(pdev); ^~~~~~~~~~~~~~~~ drivers/net//wireless/realtek/rtwlan/pci.c: At top level: drivers/net//wireless/realtek/rtwlan/pci.c:1213:1: warning: data definition has no type or storage class module_pci_driver(rtw_pci_driver); ^~~~~~~~~~~~~~~~~ drivers/net//wireless/realtek/rtwlan/pci.c:1213:1: error: type defaults to 'int' in declaration of 'module_pci_driver' [-Werror=implicit-int] drivers/net//wireless/realtek/rtwlan/pci.c:1213:1: warning: parameter names (without types) in function declaration drivers/net//wireless/realtek/rtwlan/pci.c:1189:26: warning: 'rtw_pci_driver' defined but not used [-Wunused-variable] static struct pci_driver rtw_pci_driver = { ^~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +/pcie_capability_read_word +1009 drivers/net//wireless/realtek/rtwlan/pci.c d6f77d8d Yan-Hsuan Chuang 2018-09-21 995 d6f77d8d Yan-Hsuan Chuang 2018-09-21 996 static void rtw_pci_parse_configuration(struct rtw_dev *rtwdev, d6f77d8d Yan-Hsuan Chuang 2018-09-21 997 struct pci_dev *pdev) d6f77d8d Yan-Hsuan Chuang 2018-09-21 998 { d6f77d8d Yan-Hsuan Chuang 2018-09-21 999 u16 link_control; d6f77d8d Yan-Hsuan Chuang 2018-09-21 1000 u8 config; d6f77d8d Yan-Hsuan Chuang 2018-09-21 1001 d6f77d8d Yan-Hsuan Chuang 2018-09-21 1002 /* Disable Clk Request */ d6f77d8d Yan-Hsuan Chuang 2018-09-21 1003 pci_write_config_byte(pdev, 0x81, 0); d6f77d8d Yan-Hsuan Chuang 2018-09-21 1004 /* leave D3 mode */ d6f77d8d Yan-Hsuan Chuang 2018-09-21 1005 pci_write_config_byte(pdev, 0x44, 0); d6f77d8d Yan-Hsuan Chuang 2018-09-21 1006 pci_write_config_byte(pdev, 0x04, 0x06); d6f77d8d Yan-Hsuan Chuang 2018-09-21 1007 pci_write_config_byte(pdev, 0x04, 0x07); d6f77d8d Yan-Hsuan Chuang 2018-09-21 1008 d6f77d8d Yan-Hsuan Chuang 2018-09-21 @1009 pcie_capability_read_word(pdev, PCI_EXP_LNKCTL, &link_control); d6f77d8d Yan-Hsuan Chuang 2018-09-21 1010 d6f77d8d Yan-Hsuan Chuang 2018-09-21 1011 pci_read_config_byte(pdev, 0x98, &config); d6f77d8d Yan-Hsuan Chuang 2018-09-21 1012 config |= BIT(4); d6f77d8d Yan-Hsuan Chuang 2018-09-21 1013 pci_write_config_byte(pdev, 0x98, config); d6f77d8d Yan-Hsuan Chuang 2018-09-21 1014 d6f77d8d Yan-Hsuan Chuang 2018-09-21 1015 pci_write_config_byte(pdev, 0x70f, 0x17); d6f77d8d Yan-Hsuan Chuang 2018-09-21 1016 } d6f77d8d Yan-Hsuan Chuang 2018-09-21 1017 d6f77d8d Yan-Hsuan Chuang 2018-09-21 1018 static int rtw_pci_claim(struct rtw_dev *rtwdev, struct pci_dev *pdev) d6f77d8d Yan-Hsuan Chuang 2018-09-21 1019 { d6f77d8d Yan-Hsuan Chuang 2018-09-21 1020 int ret; d6f77d8d Yan-Hsuan Chuang 2018-09-21 1021 d6f77d8d Yan-Hsuan Chuang 2018-09-21 1022 ret = pci_enable_device(pdev); d6f77d8d Yan-Hsuan Chuang 2018-09-21 1023 if (ret) { d6f77d8d Yan-Hsuan Chuang 2018-09-21 1024 rtw_err(rtwdev, "failed to enable pci device\n"); d6f77d8d Yan-Hsuan Chuang 2018-09-21 1025 return ret; d6f77d8d Yan-Hsuan Chuang 2018-09-21 1026 } d6f77d8d Yan-Hsuan Chuang 2018-09-21 1027 d6f77d8d Yan-Hsuan Chuang 2018-09-21 1028 pci_set_master(pdev); d6f77d8d Yan-Hsuan Chuang 2018-09-21 1029 pci_set_drvdata(pdev, rtwdev->hw); d6f77d8d Yan-Hsuan Chuang 2018-09-21 1030 SET_IEEE80211_DEV(rtwdev->hw, &pdev->dev); d6f77d8d Yan-Hsuan Chuang 2018-09-21 1031 d6f77d8d Yan-Hsuan Chuang 2018-09-21 1032 return 0; d6f77d8d Yan-Hsuan Chuang 2018-09-21 1033 } d6f77d8d Yan-Hsuan Chuang 2018-09-21 1034 d6f77d8d Yan-Hsuan Chuang 2018-09-21 1035 static void rtw_pci_declaim(struct rtw_dev *rtwdev, struct pci_dev *pdev) d6f77d8d Yan-Hsuan Chuang 2018-09-21 1036 { d6f77d8d Yan-Hsuan Chuang 2018-09-21 @1037 pci_clear_master(pdev); d6f77d8d Yan-Hsuan Chuang 2018-09-21 1038 pci_disable_device(pdev); d6f77d8d Yan-Hsuan Chuang 2018-09-21 1039 } d6f77d8d Yan-Hsuan Chuang 2018-09-21 1040 :::::: The code at line 1009 was first introduced by commit :::::: d6f77d8d40f1f149ed8722a46f3803c0b09fb642 rtwlan: hci files :::::: TO: Yan-Hsuan Chuang <[email protected]> :::::: CC: 0day robot <[email protected]> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
