> On Thu, Sep 27, 2018 at 11:01:48AM +0200, Lorenzo Bianconi wrote:
> > Add mt76x0e_register_device routine in pci_init.c
> > to initialize the device during hw probe.
> >
> > Signed-off-by: Lorenzo Bianconi <lorenzo.bianc...@redhat.com>
> > ---
> > .../wireless/mediatek/mt76/mt76x0/Makefile | 2 +-
> > .../net/wireless/mediatek/mt76/mt76x0/init.c | 10 +--
> > .../wireless/mediatek/mt76/mt76x0/mt76x0.h | 2 +
> > .../net/wireless/mediatek/mt76/mt76x0/pci.c | 2 +-
> > .../wireless/mediatek/mt76/mt76x0/pci_init.c | 65 +++++++++++++++++++
> > .../wireless/mediatek/mt76/mt76x02_eeprom.h | 1 +
> > 6 files changed, 73 insertions(+), 9 deletions(-)
> > create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x0/pci_init.c
> >
> > diff --git a/drivers/net/wireless/mediatek/mt76/mt76x0/Makefile
> > b/drivers/net/wireless/mediatek/mt76/mt76x0/Makefile
> > index 30c84a557076..daa4929bdee6 100644
> > --- a/drivers/net/wireless/mediatek/mt76/mt76x0/Makefile
> > +++ b/drivers/net/wireless/mediatek/mt76/mt76x0/Makefile
> > @@ -6,7 +6,7 @@ mt76x0-common-y := \
> > init.o main.o trace.o eeprom.o phy.o \
> > mac.o debugfs.o tx.o
> > mt76x0u-y := usb.o usb_mcu.o usb_init.o
> > -mt76x0e-y := pci.o pci_mcu.o
> > +mt76x0e-y := pci.o pci_mcu.o pci_init.o
>
> How much {pci,usb}_{init,mcu}.c files are expected to grow?
> For now they are about between 100 and 200 lines of code
> and I do not see reason to move code into separate files
> so far. It could be easy placed in usb.c and pci.c files.
> But if the files will grow, I'm ok with code moving.
At the moment I do not know how much {pci,usb}_{init,mcu}.c will
grow, I guess a little bit more. Anyway I would prefer to have
in {pci/usb}.c just bus specific code (but it is a matter of taste
actually)
Regards,
Lorenzo
>
> Thanks
> Stanislaw
