On Wed, Oct 03, 2018 at 11:15:37AM +0200, Lorenzo Bianconi wrote: > > After > > > > b11e19694dc9 "mt76x0: add ieee80211_ops ops pointer to mt76x0_alloc_device > > signature" > > > > I have new crashs when remove mt76x0u and mt76x2u devices. > > I can not provide calltrace because some other warning/traces > > show up instantly after the problem happen and mask prints > > for initall problem. Then the machine hungs. > > > > Anyway bisection blame b11e19694dc9 commit and I confirm that problem > > not happen before this commit. I also applied the fix with I just > > posted, so this is diffrent issue. > > Hi Stanislaw, > > I do not know if it is related or not, but could you please try following > patch: > > Regards, > Lorenzo > > --- a/drivers/net/wireless/mediatek/mt76/mt76x0/usb.c > +++ b/drivers/net/wireless/mediatek/mt76/mt76x0/usb.c > @@ -179,11 +179,11 @@ static int mt76x0u_register_device(struct mt76x0_dev > *dev) > struct ieee80211_hw *hw = dev->mt76.hw; > int err; > > - err = mt76u_mcu_init_rx(&dev->mt76); > + err = mt76u_alloc_queues(&dev->mt76); > if (err < 0) > return err; > > - err = mt76u_alloc_queues(&dev->mt76); > + err = mt76u_mcu_init_rx(&dev->mt76); > if (err < 0) > return err;
It still crashes. You can not reproduce the problem ? It's 100% reproducible for me, when I unplug mt76x0u or mt76x2 device. Thanks Stanislaw
