On 2018-10-09 09:35, Stanislaw Gruszka wrote:
> On Mon, Oct 08, 2018 at 08:11:45PM +0200, Felix Fietkau wrote:
>> On 2018-10-08 14:40, Lorenzo Bianconi wrote:
>> > Fix restore value configured in 0x2124 register in
>> > mt76x0_phy_recalibrate_after_assoc routine.
>> >
>> > Fixes: 10de7a8b4ab9 ("mt76x0: phy files")
>> > Signed-off-by: Lorenzo Bianconi <[email protected]>
>> > ---
>> > drivers/net/wireless/mediatek/mt76/mt76x0/phy.c | 3 +--
>> > 1 file changed, 1 insertion(+), 2 deletions(-)
>> >
>> > diff --git a/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c
>> > b/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c
>> > index 99e0a91a2f99..d18942e54048 100644
>> > --- a/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c
>> > +++ b/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c
>> > @@ -734,8 +734,7 @@ void mt76x0_phy_recalibrate_after_assoc(struct
>> > mt76x02_dev *dev)
>> > usleep_range(500, 700);
>> >
>> > reg_val = mt76_rr(dev, 0x2124);
>> > - reg_val &= 0xffffff7e;
>> > - mt76_wr(dev, 0x2124, reg_val);
>> > + mt76_wr(dev, 0x2124, 0xffffff7e);
>> I'm pretty sure you can drop the mt76_rr as well. Also, you can refer to
>> 0x2124 as MT_BBP(IBI, 9).
>
> I think is needed we do:
>
> reg_val = mt76_rr(dev, 0x2124);
> mt76_wr(dev, 0x2124, 0xffffff7e);
>
> CALIBRATE
>
> mt76_wr(dev, 0x2124, reg_val);
>
> so seems we have to restore orginal value after calibration.
>
> Referencing as MT_BBP(IBI, 9) is obviously fine.
Yes, that makes more sense.
- Felix
