Hi Hans, I love your patch! Yet something to improve:
[auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on v4.19-rc7 next-20181010] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Hans-de-Goede/brcmfmac-Add-support-for-getting-nvram-contents-from-EFI-variables/20181010-211419 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master config: i386-randconfig-c0-10102322 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c: In function 'brcmf_fw_request_nvram_done': >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c:529:44: error: >> passing argument 1 of 'brcmf_fw_nvram_from_efi' from incompatible pointer >> type [-Werror=incompatible-pointer-types] else if ((data = brcmf_fw_nvram_from_efi(cur->path, &data_len))) ^~~ drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c:491:12: note: expected 'size_t * {aka unsigned int *}' but argument is of type 'const char *' static u8 *brcmf_fw_nvram_from_efi(size_t *data_len) { return NULL; } ^~~~~~~~~~~~~~~~~~~~~~~ >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c:529:20: error: >> too many arguments to function 'brcmf_fw_nvram_from_efi' else if ((data = brcmf_fw_nvram_from_efi(cur->path, &data_len))) ^~~~~~~~~~~~~~~~~~~~~~~ drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c:491:12: note: declared here static u8 *brcmf_fw_nvram_from_efi(size_t *data_len) { return NULL; } ^~~~~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +/brcmf_fw_nvram_from_efi +529 drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c 507 508 static int brcmf_fw_request_nvram_done(const struct firmware *fw, void *ctx) 509 { 510 struct brcmf_fw *fwctx = ctx; 511 struct brcmf_fw_item *cur; 512 bool free_bcm47xx_nvram = false; 513 bool kfree_nvram = false; 514 u32 nvram_length = 0; 515 void *nvram = NULL; 516 u8 *data = NULL; 517 size_t data_len; 518 519 brcmf_dbg(TRACE, "enter: dev=%s\n", dev_name(fwctx->dev)); 520 521 cur = &fwctx->req->items[fwctx->curpos]; 522 523 if (fw && fw->data) { 524 data = (u8 *)fw->data; 525 data_len = fw->size; 526 } else { 527 if ((data = bcm47xx_nvram_get_contents(&data_len))) 528 free_bcm47xx_nvram = true; > 529 else if ((data = brcmf_fw_nvram_from_efi(cur->path, > &data_len))) 530 kfree_nvram = true; 531 else if (!(cur->flags & BRCMF_FW_REQF_OPTIONAL)) 532 goto fail; 533 } 534 535 if (data) 536 nvram = brcmf_fw_nvram_strip(data, data_len, &nvram_length, 537 fwctx->req->domain_nr, 538 fwctx->req->bus_nr); 539 540 if (free_bcm47xx_nvram) 541 bcm47xx_nvram_release_contents(data); 542 if (kfree_nvram) 543 kfree(data); 544 545 release_firmware(fw); 546 if (!nvram && !(cur->flags & BRCMF_FW_REQF_OPTIONAL)) 547 goto fail; 548 549 brcmf_dbg(TRACE, "nvram %p len %d\n", nvram, nvram_length); 550 cur->nv_data.data = nvram; 551 cur->nv_data.len = nvram_length; 552 return 0; 553 554 fail: 555 return -ENOENT; 556 } 557 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
