On 10/11/2018 12:33 PM, Johannes Berg wrote:
> On Thu, 2018-10-11 at 12:30 +0530, Ajay Singh wrote:
>>>> + if (queue_count > FLOW_CONTROL_UPPER_THRESHOLD) {
>>>> + netif_stop_queue(wilc->vif[0]->ndev);
>>>> + netif_stop_queue(wilc->vif[1]->ndev);
>>>> + }
>>> It seems like a pretty bad idea to hard-code two interfaces, we do
>>> dynamic addition/removal these days, in *particular* for P2P.
>>>
>> Did you mean it not good to call stop queue for both the interfaces.
>> Can you please provide some more details about this comments.
> No, I mean you should be more dynamic and have e.g. a list of interfaces
> (actually, you can use cfg80211's list, I believe!), instead of hard-
> coding that you have "wlan0" and "p2p0".
I got your point now. I will check on this to add the support.
Regards,
Ajay
