On Wed, Oct 24, 2018 at 11:56:53AM +0300, Kalle Valo wrote: > Dan Carpenter <[email protected]> writes: > > > It looks like we wanted to print a maximum of BSSList_rid.ssidLen bytes > > of the ssid, but we accidentally use "%*s" (width) instead of "%.*s" > > (precision) so if the ssid doesn't have a NUL terminator this could lead > > to an overflow. > > > > Fixes: e174961ca1a0 ("net: convert print_mac to %pM") > > Signed-off-by: Dan Carpenter <[email protected]> > > --- > > Static analsysis. Not tested. > > IMHO this part (after "---" line) is important information and should be > part of commit log. I can fix that. >
In my experience most maintainers disagree (with varying degrees of intensity). regards, dan carpenter
