Re: [PATCH 4/5] mt76x2: initialize fall-back rate registers

[Lorenzo Bianconi]

>
> Initialize MT_LG_FBK_CFG{0,1} and MT_VHT_HT_FBK_CFG0 registers.
> MT_VHT_HT_FBK_CFG1 was already configured.
>
> Signed-off-by: Stanislaw Gruszka <sgrus...@redhat.com>
> ---
>  drivers/net/wireless/mediatek/mt76/mt76x2/init.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt76x2/init.c 
> b/drivers/net/wireless/mediatek/mt76/mt76x2/init.c
> index 54a9b5fac787..16fd514b5207 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt76x2/init.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt76x2/init.c
> @@ -140,7 +140,10 @@ void mt76_write_mac_initvals(struct mt76x02_dev *dev)
>                 { MT_WPDMA_DELAY_INT_CFG,       0x94ff0000 },
>                 { MT_TX_SW_CFG3,                0x00000004 },
>                 { MT_HT_FBK_TO_LEGACY,          0x00001818 },
> +               { MT_VHT_HT_FBK_CFG0,           0x65432100 },
>                 { MT_VHT_HT_FBK_CFG1,           0xedcba980 },
> +               { MT_LG_FBK_CFG0,               0xedcba988 },
> +               { MT_LG_FBK_CFG1,               0x87872100 },
>                 { MT_PROT_AUTO_TX_CFG,          0x00830083 },
>                 { MT_HT_CTRL_CFG,               0x000001ff },
>         };

I do not think this patch is necessary since these value are default ones:

root@lede:/sys/kernel/debug/ieee80211/phy0/mt76# echo 0x1354 > regidx
root@lede:/sys/kernel/debug/ieee80211/phy0/mt76# cat regval
0x65432100
root@lede:/sys/kernel/debug/ieee80211/phy0/mt76# echo 0x135c > regidx
root@lede:/sys/kernel/debug/ieee80211/phy0/mt76# cat regval
0xedcba988
root@lede:/sys/kernel/debug/ieee80211/phy0/mt76# echo 0x1360 > regidx
root@lede:/sys/kernel/debug/ieee80211/phy0/mt76# cat regval
0x87872100

Regards,
Lorenzo

> --
> 1.9.3
>