On Sat, 2018-10-06 at 17:00 -0500, Larry Finger wrote: > On 10/6/18 3:17 PM, Joe Perches wrote: > > On Sat, 2018-10-06 at 15:05 -0500, Larry Finger wrote: > > > On 10/6/18 2:30 PM, Kalle Valo wrote: > > > > Colin King <[email protected]> writes: > > > > > > > > > From: Colin Ian King <[email protected]> > > > > > > > > > > The switch case RATR_INX_WIRELESS_MC has a missing break, this seems > > > > > to be unintentional as the setting of variable ret gets overwritten > > > > > when the case falls through to the following RATR_INX_WIRELESS_AC_5N > > > > > case. Fix this by adding in the missing break. > > > > > > > > > > Detected by CoverityScan, CID#1167237 ("Missing break in switch") > > > > > > > > > > Fixes: 3c05bedb5fef ("Staging: rtl8812ae: Add Realtek 8821 PCI WIFI > > > > > driver") > > > > > Signed-off-by: Colin Ian King <[email protected]> > > > > > --- > > > > > drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c | 1 + > > > > > > > > Is the fixes line correct? This patch is not for staging. > > > > > > No, the correct fixes commit is 21e4b0726dc67 (" rtlwifi: rtl8821ae: Move > > > driver > > > from staging to regular tree"). > > > > > > This driver was initially placed in staging as it was needed for a special > > > project, which is the commit that Colin used. As the patch subject > > > states, the > > > driver was later moved to the regular wireless tree. > > > > > > That break is required, thus ACKed-by: Larry Finger > > > <[email protected]> > > > > Why not remove this entirely and use the generic routine in > > drivers/net/wireless/realtek/rtlwifi/base.c? > > > > Is there a real difference? > > I did not see any difference other than the removal of a bunch of magic > numbers > and better formatting.
Me neither.
