On 7/6/18 2:29 PM, Johannes Berg wrote: > Hi Gustavo, > >> In preparation to enabling -Wimplicit-fallthrough, mark switch cases >> where we are expecting to fall through. > > You dropped the remark saying you didn't review them, but did you? > I'll add it in v2. >> case NL80211_CHAN_WIDTH_20: >> if (!ht_cap->ht_supported) >> return false; >> + /* else: fall through */ > > What's the point in else:? > > We also don't necessarily write > > if (!...) > return false; > else > do_something(); > > but rather > > if (!...) > return false; > do_something(). > > I think I'd prefer without the "else:" > Sure thing. I'll change this in v2. I'll send v2 shortly. Thanks for the feedback. -- Gustavo
