Priit Laes <[email protected]> writes:

> Now that we use library macros, we can drop internal copies
>
> Signed-off-by: Priit Laes <[email protected]>
> ---
>  drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_int.h | 7 +-------

Also here this is about brcmsmac.

> --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_int.h
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_int.h
> @@ -220,13 +220,6 @@ enum phy_cal_mode {
>  #define BB_MULT_MASK         0x0000ffff
>  #define BB_MULT_VALID_MASK   0x80000000
>  
> -#define CORDIC_AG    39797
> -#define      CORDIC_NI       18
> -#define      FIXED(X)        ((s32)((X) << 16))
> -
> -#define      FLOAT(X) \
> -     (((X) >= 0) ? ((((X) >> 15) + 1) >> 1) : -((((-(X)) >> 15) + 1) >> 1))
> -

Ah, now I see the benefit from patch 2. IMHO you could just fold patch 3
into patch 2, no need to split them.

-- 
Kalle Valo

Reply via email to