Ahmad Masri <[email protected]> writes:

> Add ACS offload to let the device select a channel for AP from
> a list of channels that the user-space provides. ACS can customize
> the method of AP channel selection and add parameters like traffic
> load, number of APs on channel and more.
>
> Change-Id: I18cb8460b9418512ac7ac9f76fe8f7f379f2478b
> Signed-off-by: Ahmad Masri <[email protected]>

No Change-Id, please.

> @@ -4662,6 +4680,7 @@ struct wireless_dev {
>       unsigned long cac_start_time;
>       unsigned int cac_time_ms;
>  
> +     bool acs_started;
>  #ifdef CONFIG_CFG80211_WEXT

Empty line before ifdef? Just like it had before your patch.

> +void cfg80211_acs_result(struct net_device *netdev,
> +                      const struct cfg80211_chan_def *chandef,
> +                      enum nl80211_acs_status status, gfp_t gfp)
> +{
> +     struct wireless_dev *wdev = netdev->ieee80211_ptr;
> +     struct wiphy *wiphy = wdev->wiphy;
> +     struct cfg80211_registered_device *rdev = wiphy_to_rdev(wiphy);
> +
> +     if (WARN_ON(!wdev->acs_started))
> +             return;
> +
> +     switch (status) {
> +     case NL80211_ACS_SUCCESS:
> +             if (!chandef) {
> +                     WARN_ON(1);
> +                     goto out;
> +             }

if (WARN_ON(!chandef))
        goto out;

-- 
Kalle Valo

Reply via email to