On 1/3/2019 8:46 AM, Chi-Hsien Lin wrote:
From: Lo-Hsiang Lo <[email protected]>
Set up wiphy->wowlan_config and a dummy wowlan filter so brcmfmac can
remain connected during suspend. Enable an unicast packet filter during
suspend so ping packets can wake up the system.
This basically enables a default wowlan configuration, but why do we
want this in the driver. The struct wiphy::wowlan_config member is
primarily managed by cfg80211 (see nl80211_set_wowlan()) upon user-space
request.
If user-space reconfigures with no wowlan triggers the default
configuration is freed, but as we have no .set_wakeup() callback the
configuration in firmware remains unchanged so things are out of sync.
So I would discourage this default approach and just let user-space deal
with wowlan configuration.
Regards,
Arend
