Kalle Valo <[email protected]> writes:

> Larry Finger <[email protected]> writes:
>
>> The traditional license information is replaced by the SPDX form. There
>> are no code changes.
>>
>> Signed-off-by: Larry Finger <[email protected]>
>
> [...]
>
>> --- a/drivers/net/wireless/realtek/rtlwifi/base.c
>> +++ b/drivers/net/wireless/realtek/rtlwifi/base.c
>> @@ -1,27 +1,5 @@
>> -/******************************************************************************
>> - *
>> - * Copyright(c) 2009-2012  Realtek Corporation.
>> - *
>> - * This program is free software; you can redistribute it and/or modify it
>> - * under the terms of version 2 of the GNU General Public License as
>> - * published by the Free Software Foundation.
>
> So the way I see this is GPLv2 only (so GPLv3 is not included).
>
>> +/* SPDX-License-Identifier: GPL-2.0+ */
>
> But this is GPLv2 or later (including GPLv3 for example).
> LICENSES/preferred/GPL-2.0 contains more info about the tags.
>
> Also for SPDX tags in .c files you should use C++ comment style '//',

Oh, but do not that '//' should be used only with the first line
containing the SPDX tag (in a .c file). The following lines with
copyrights should use '/* */' normally.

-- 
Kalle Valo

Reply via email to