Larry Finger <[email protected]> wrote:
> There are a number of CamelCase variables remaining in the source
> files of modules rtl_pci, rtl_usb, and rtlwifi.
>
> The following checkpatch excettions are also fixed:
>
> for_kalle1/0001-rtlwifi-Remove-CamelCase-variables-from-base-code.patch
> -----------------------------------------------------------------------
> CHECK: Unnecessary parentheses around
> 'rtlefuse->efuse_map[EFUSE_INIT_MAP][base + i] !=
> rtlefuse->efuse_map[EFUSE_MODIFY_MAP][base + i]'
> #68: FILE: drivers/net/wireless/realtek/rtlwifi/efuse.c:377:
> + if ((rtlefuse->efuse_map[EFUSE_INIT_MAP][base + i] !=
> + rtlefuse->efuse_map[EFUSE_MODIFY_MAP][base + i])
> ||
> + (rtlefuse->efuse_map[EFUSE_INIT_MAP][base + i +
> 1] !=
> + rtlefuse->efuse_map[EFUSE_MODIFY_MAP][base + i +
> 1])) {
>
> CHECK: Unnecessary parentheses around
> 'rtlefuse->efuse_map[EFUSE_INIT_MAP][base + i + 1] !=
> rtlefuse->efuse_map[EFUSE_MODIFY_MAP][base + i +
> 1]'
> #68: FILE: drivers/net/wireless/realtek/rtlwifi/efuse.c:377:
> + if ((rtlefuse->efuse_map[EFUSE_INIT_MAP][base + i] !=
> + rtlefuse->efuse_map[EFUSE_MODIFY_MAP][base + i])
> ||
> + (rtlefuse->efuse_map[EFUSE_INIT_MAP][base + i +
> 1] !=
> + rtlefuse->efuse_map[EFUSE_MODIFY_MAP][base + i +
> 1])) {
>
> WARNING: line over 80 characters
> #70: FILE: drivers/net/wireless/realtek/rtlwifi/efuse.c:379:
> + (rtlefuse->efuse_map[EFUSE_INIT_MAP][base + i +
> 1] !=
>
> CHECK: No space is necessary after a cast
> #186: FILE: drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c:396:
> + status->rx_is40mhzpacket = (bool) GET_RX_DESC_BW(pdesc);
>
> CHECK: No space is necessary after a cast
> #208: FILE: drivers/net/wireless/realtek/rtlwifi/rtl8192ce/trx.c:335:
> + stats->rx_is40mhzpacket = (bool) GET_RX_DESC_BW(pdesc);
>
> CHECK: No space is necessary after a cast
> #243: FILE: drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c:301:
> + stats->rx_is40mhzpacket = (bool) GET_RX_DESC_BW(pdesc);
>
> CHECK: No space is necessary after a cast
> #252: FILE: drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c:368:
> + stats.rx_is40mhzpacket = (bool) GET_RX_DESC_BW(rxdesc);
>
> CHECK: No space is necessary after a cast
> #265: FILE: drivers/net/wireless/realtek/rtlwifi/rtl8192de/trx.c:475:
> + stats->rx_is40mhzpacket = (bool) GET_RX_DESC_BW(pdesc);
>
> WARNING: Unnecessary space before function pointer arguments
> #455: FILE: drivers/net/wireless/realtek/rtlwifi/wifi.h:1462:
> + void (*writen_sync) (struct rtl_priv *rtlpriv, u32 addr, void *buf,
>
> WARNING: Unnecessary space before function pointer arguments
> #483: FILE: drivers/net/wireless/realtek/rtlwifi/wifi.h:2257:
> + void (*fill_fake_txdesc) (struct ieee80211_hw *hw, u8 *pdesc,
>
> Note that not all checkpatch exceptions are addressed. Those will be
> handled in later patches.
>
> Signed-off-by: Larry Finger <[email protected]>
8 patches applied to wireless-drivers-next.git, thanks.
e703c5dd2d69 rtlwifi: Remove CamelCase variables from base code
2171def56daf rtlwifi: btcoexist: Remove CamelCase variable
d420110635ad rtlwifi: rtl8188ee: Remove CamelCase variable
ff9704538e6d rtlwifi: rtl8192{c,u}: Remove CamelCase variables
b83faeda028b rtlwifi: rtl8188de: Remove CamelCase variables
2a83ad1fe330 rtlwifi: rtl8192se: Remove CamelCase variables
92a1aa25c782 rtlwifi: rtl8723{be,ae}: Remove CamelCase variables
9c66a7e5d39c rtlwifi: rtl8821ae: Remove CamelCase variables
--
https://patchwork.kernel.org/patch/10813947/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
