Sergey Matyukevich <[email protected]> writes:

> From: Igor Mitsyanko <[email protected]>
>
> Use scan duration param for both active and passive scan dwell times.
> Document what different types of dwell times are used for. Explicitly
> specify that if unset, automatic selection by device firmware
> will be used.
>
> Signed-off-by: Igor Mitsyanko <[email protected]>
> ---
>  drivers/net/wireless/quantenna/qtnfmac/commands.c | 49 
> ++++++++++++++++++-----
>  drivers/net/wireless/quantenna/qtnfmac/qlink.h    | 11 ++++-
>  2 files changed, 49 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/net/wireless/quantenna/qtnfmac/commands.c 
> b/drivers/net/wireless/quantenna/qtnfmac/commands.c
> index 62edddb8551e..e58495403dde 100644
> --- a/drivers/net/wireless/quantenna/qtnfmac/commands.c
> +++ b/drivers/net/wireless/quantenna/qtnfmac/commands.c
> @@ -11,6 +11,13 @@
>  #include "bus.h"
>  #include "commands.h"
>  
> +#define QTNF_SCAN_TIME_AUTO  0
> +
> +/* Let device itself to select best values for current conditions */
> +#define QTNF_SCAN_DWELL_ACTIVE_DEFAULT               QTNF_SCAN_TIME_AUTO
> +#define QTNF_SCAN_DWELL_PASSIVE_DEFAULT              QTNF_SCAN_TIME_AUTO
> +#define QTNF_SCAN_SAMPLE_DURATION_DEFAULT    QTNF_SCAN_TIME_AUTO

These three defines look odd. Why not just use QTNF_SCAN_TIME_AUTO
directly?

-- 
Kalle Valo

Reply via email to