tree: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git netlink-validate-build-test-2 head: eefd811df5bc7a7ad129ce4ac3ff473802736ad9 commit: 1217489aab75c491228eeb01ebbceabd29e989cc [3/7] netlink: make validation more configurable for future strictness config: ia64-allmodconfig (attached as .config) compiler: ia64-linux-gcc (GCC) 8.1.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout 1217489aab75c491228eeb01ebbceabd29e989cc # save the attached .config to linux build tree GCC_VERSION=8.1.0 make.cross ARCH=ia64
All errors (new ones prefixed by >>):
net/sched/act_tunnel_key.c: In function 'tunnel_key_copy_opts':
>> net/sched/act_tunnel_key.c:128:8: error: implicit declaration of function
>> 'nla_validate'; did you mean 'key_validate'?
>> [-Werror=implicit-function-declaration]
err = nla_validate(head, len, TCA_TUNNEL_KEY_ENC_OPTS_MAX,
^~~~~~~~~~~~
key_validate
cc1: some warnings being treated as errors
vim +128 net/sched/act_tunnel_key.c
0ed5269f Simon Horman 2018-06-26 121
0ed5269f Simon Horman 2018-06-26 122 static int tunnel_key_copy_opts(const
struct nlattr *nla, u8 *dst,
0ed5269f Simon Horman 2018-06-26 123 int dst_len,
struct netlink_ext_ack *extack)
0ed5269f Simon Horman 2018-06-26 124 {
0ed5269f Simon Horman 2018-06-26 125 int err, rem, opt_len, len =
nla_len(nla), opts_len = 0;
0ed5269f Simon Horman 2018-06-26 126 const struct nlattr *attr, *head =
nla_data(nla);
0ed5269f Simon Horman 2018-06-26 127
0ed5269f Simon Horman 2018-06-26 @128 err = nla_validate(head, len,
TCA_TUNNEL_KEY_ENC_OPTS_MAX,
0ed5269f Simon Horman 2018-06-26 129 enc_opts_policy,
extack);
0ed5269f Simon Horman 2018-06-26 130 if (err)
0ed5269f Simon Horman 2018-06-26 131 return err;
0ed5269f Simon Horman 2018-06-26 132
0ed5269f Simon Horman 2018-06-26 133 nla_for_each_attr(attr, head, len, rem)
{
0ed5269f Simon Horman 2018-06-26 134 switch (nla_type(attr)) {
0ed5269f Simon Horman 2018-06-26 135 case
TCA_TUNNEL_KEY_ENC_OPTS_GENEVE:
0ed5269f Simon Horman 2018-06-26 136 opt_len =
tunnel_key_copy_geneve_opt(attr, dst,
0ed5269f Simon Horman 2018-06-26 137
dst_len, extack);
0ed5269f Simon Horman 2018-06-26 138 if (opt_len < 0)
0ed5269f Simon Horman 2018-06-26 139 return opt_len;
0ed5269f Simon Horman 2018-06-26 140 opts_len += opt_len;
0ed5269f Simon Horman 2018-06-26 141 if (dst) {
0ed5269f Simon Horman 2018-06-26 142 dst_len -=
opt_len;
0ed5269f Simon Horman 2018-06-26 143 dst += opt_len;
0ed5269f Simon Horman 2018-06-26 144 }
0ed5269f Simon Horman 2018-06-26 145 break;
0ed5269f Simon Horman 2018-06-26 146 }
0ed5269f Simon Horman 2018-06-26 147 }
0ed5269f Simon Horman 2018-06-26 148
0ed5269f Simon Horman 2018-06-26 149 if (!opts_len) {
0ed5269f Simon Horman 2018-06-26 150 NL_SET_ERR_MSG(extack, "Empty
list of tunnel options");
0ed5269f Simon Horman 2018-06-26 151 return -EINVAL;
0ed5269f Simon Horman 2018-06-26 152 }
0ed5269f Simon Horman 2018-06-26 153
0ed5269f Simon Horman 2018-06-26 154 if (rem > 0) {
0ed5269f Simon Horman 2018-06-26 155 NL_SET_ERR_MSG(extack,
"Trailing data after parsing tunnel key options attributes");
0ed5269f Simon Horman 2018-06-26 156 return -EINVAL;
0ed5269f Simon Horman 2018-06-26 157 }
0ed5269f Simon Horman 2018-06-26 158
0ed5269f Simon Horman 2018-06-26 159 return opts_len;
0ed5269f Simon Horman 2018-06-26 160 }
0ed5269f Simon Horman 2018-06-26 161
:::::: The code at line 128 was first introduced by commit
:::::: 0ed5269f9e41f495c8e9020c85f5e1644c1afc57 net/sched: add tunnel option
support to act_tunnel_key
:::::: TO: Simon Horman <[email protected]>
:::::: CC: David S. Miller <[email protected]>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
