Stanislaw Gruszka <sgrus...@redhat.com> writes:

> Upstream RT3883 support patches cared by openwrt for quite
> a while now.
>
> Patches do not contain the changelog and generate this checkpatch.pl
> warning:
>
> WARNING: Missing commit description - Add an appropriate one

No empty commit logs, please. They are very annoying.

> but I do not see much sense for fixing that.
>
> Gabor Juhos (21):
>   rt2x00: rt2800lib: enable support for RT3883
>   rt2x00: rt2800lib: add rf_vals for RF3853
>   rt2x00: rt2800lib: enable VCO calibration for RF3853
>   rt2x00: rt2800lib: add channel configuration function for RF3853
>   rt2x00: rt2800lib: enable RF3853 support
>   rt2x00: rt2800lib: add MAC register initialization for RT3883
>   rt2x00: rt2800soc: fix rt2800soc_disable_radio for RT3883
>   rt2x00: rt2800lib: add BBP register initialization for RT3883
>   rt2x00: rt2800lib: add RFCSR initialization for RT3883
>   rt2x00: rt2800lib: use the extended EEPROM map for RT3883
>   rt2x00: rt2800lib: force rf type to RF3853 on RT3883
>   rt2x00: rt2800lib: add channel configuration code for RT3883
>   rt2x00: rt2800lib: fix txpower_to_dev function for RT3883
>   rt2x00: rt2800lib: use correct txpower calculation function for RT3883
>   rt2x00: rt2800lib: hardcode txmixer gain values to zero for RT3883
>   rt2x00: rt2800lib: use correct [RT]XWI size for RT3883
>   rt2x00: rt2800lib: fix antenna configuration for RT3883
>   rt2x00: rt2800lib: fix LNA gain configuration for RT3883
>   rt2x00: rt2800lib: fix VGC setup for RT3883
>   rt2x00: rt2800lib: fix EEPROM LNA validation for RT3883
>   rt2x00: rt2800lib: fix txpower compensation for RT3883
>
>  drivers/net/wireless/ralink/rt2x00/rt2800.h    |  19 +-
>  drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 598 
> ++++++++++++++++++++++++-
>  drivers/net/wireless/ralink/rt2x00/rt2800soc.c |   9 +-
>  3 files changed, 607 insertions(+), 19 deletions(-)

I'm not seeing the point of of all these small patches, they are all
about adding RT3883 support, right? I think it it would be easier to
combine all these to one bigger patch and write a proper commit log
explaining the background and what has been tested etc. It wouldn't be
that big patch anyway.

-- 
Kalle Valo

Reply via email to