Zefir Kurtisi <[email protected]> writes: > On 6/11/19 3:43 PM, Kalle Valo wrote: >> Zefir Kurtisi <[email protected]> writes: >> >>> Changes to v1: >>> * typos fixed in commit-message >>> -- >>> >>> In commit '3c0efb745a17 ("ath9k: discard undersized packets")' >>> the lower bound of RX packets was set to 10 (min ACK size) to >>> filter those that would otherwise be treated as invalid at >>> mac80211. >>> >>> Alas, short radar pulses are reported as PHY_ERROR frames >>> with length set to 3. Therefore their detection stopped >>> working after that commit. >>> >>> NOTE: ath9k drivers built thereafter will not pass DFS >>> certification. >>> >>> This extends the criteria for short packets to explicitly >>> handle PHY_ERROR frames. >>> >>> Signed-off-by: Zefir Kurtisi <[email protected]> >> >> Forgot to mention that the Fixes line should be before s-o-b, not in the >> title: >> >> Fixes: 3c0efb745a17 ("ath9k: discard undersized packets") >> >> I'll fix (no pun intended) that as well. >> > Thanks. Was unsure about that, checkpatch warned about format (mandatory 12 > digit > hash), but not the proper location. Will keep in mind.
I have tried to document the most important parts to the wiki: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#fixes_line_is_incorrect -- Kalle Valo
