On Wed, 2019-07-03 at 16:18 +0300, Shay Bar wrote:
> In case of HE AP-STA link, ieee80211_send_nullfunc() will not send the QOS
> NULL packet to check if AP is still associated.
> In this case, probe_send_count will be non zero and ieee80211_sta_work() will
> later disassociate the AP.
> (although it didn't really send a test QOS NULL packet).
> Fix is to decrement probe_send_count and not call ieee80211_send_nullfunc()
> in case of HE link.
>
> Signed-off-by: Shay Bar <[email protected]>
> ---
> Hope I solved all the SMTP server problems and patch is better now :)
Yep, thanks.
> if (ieee80211_hw_check(&sdata->local->hw, REPORTS_TX_ACK_STATUS)) {
> ifmgd->nullfunc_failed = false;
> - ieee80211_send_nullfunc(sdata->local, sdata, false);
> + if (!(ifmgd->flags & IEEE80211_STA_DISABLE_HE))
> + ifmgd->probe_send_count--;
> + else
> + ieee80211_send_nullfunc(sdata->local, sdata, false);
Not sure that makes sense though.
Why go through all the motions of doing the counting and all, and the
run_again() etc. when all that will happen is that we'll disconnect
anyway?
johannes
