On Thu, Aug 01, 2019 at 09:04:34AM +0200, Johannes Berg wrote: > From: Mauro Rossi <[email protected]> > > This patch fixes and preserves existing code style, and readability, > for IWL_ERR() and IWL_WARN() macros invocations recently added in dbg.c > > Fixes the following build errors with Android build system: > > /home/utente/pie-x86_kernel/kernel/drivers/net/wireless/intel/iwlwifi/fw/dbg.c: > In function '_iwl_fw_dbg_apply_point': > /home/utente/pie-x86_kernel/kernel/drivers/net/wireless/intel/iwlwifi/fw/dbg.c:2445:3: > error: call to '__compiletime_assert_2446' declared with attribute error: > BUILD_BUG_ON failed: err_str[sizeof(err_str) - 2] != '\n' > /home/utente/pie-x86_kernel/kernel/drivers/net/wireless/intel/iwlwifi/fw/dbg.c:2451:3: > error: call to '__compiletime_assert_2452' declared with attribute error: > BUILD_BUG_ON failed: err_str[sizeof(err_str) - 2] != '\n' > ... > /home/utente/pie-x86_kernel/kernel/drivers/net/wireless/intel/iwlwifi/fw/dbg.c:2789:5: > error: call to '__compiletime_assert_2790' declared with attribute error: > BUILD_BUG_ON failed: invalid_ap_str[sizeof(invalid_ap_str) - 2] != '\n' > /home/utente/pie-x86_kernel/kernel/drivers/net/wireless/intel/iwlwifi/fw/dbg.c:2800:5: > error: call to '__compiletime_assert_2801' declared with attribute error: > BUILD_BUG_ON failed: invalid_ap_str[sizeof(invalid_ap_str) - 2] != '\n' > > Fixes: 427ab6385cf3 ("iwlwifi: dbg_ini: enforce apply point early on buffer > allocation tlv") > Fixes: 57d88b116175 ("iwlwifi: dbg_ini: support debug info TLV") > Signed-off-by: Mauro Rossi <[email protected]> > Signed-off-by: Johannes Berg <[email protected]>
I can confirm that this works fine. Reviewed-by: Nathan Chancellor <[email protected]> Tested-by: Nathan Chancellor <[email protected]>
