Hi Johannes,

I love your patch! Yet something to improve:

[auto build test ERROR on wireless-drivers-next/master]
[cannot apply to v5.3-rc3 next-20190808]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:    
https://github.com/0day-ci/linux/commits/Johannes-Berg/wireless-fix-netlink-vendor-commands/20190625-220203
base:   
https://kernel.googlesource.com/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git
 master
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-9) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <[email protected]>

All errors (new ones prefixed by >>):

>> drivers/net//wireless/ti/wlcore/vendor_cmd.c:169:4: error: 'const struct 
>> wiphy_vendor_command' has no member named 'policy'
      .policy = wlcore_vendor_attr_policy,
       ^~~~~~
>> drivers/net//wireless/ti/wlcore/vendor_cmd.c:169:13: error: initialization 
>> from incompatible pointer type [-Werror=incompatible-pointer-types]
      .policy = wlcore_vendor_attr_policy,
                ^~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net//wireless/ti/wlcore/vendor_cmd.c:169:13: note: (near 
initialization for 'wlcore_vendor_commands[0].dumpit')
   drivers/net//wireless/ti/wlcore/vendor_cmd.c:179:4: error: 'const struct 
wiphy_vendor_command' has no member named 'policy'
      .policy = wlcore_vendor_attr_policy,
       ^~~~~~
   drivers/net//wireless/ti/wlcore/vendor_cmd.c:179:13: error: initialization 
from incompatible pointer type [-Werror=incompatible-pointer-types]
      .policy = wlcore_vendor_attr_policy,
                ^~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net//wireless/ti/wlcore/vendor_cmd.c:179:13: note: (near 
initialization for 'wlcore_vendor_commands[1].dumpit')
   drivers/net//wireless/ti/wlcore/vendor_cmd.c:189:4: error: 'const struct 
wiphy_vendor_command' has no member named 'policy'
      .policy = wlcore_vendor_attr_policy,
       ^~~~~~
   drivers/net//wireless/ti/wlcore/vendor_cmd.c:189:13: error: initialization 
from incompatible pointer type [-Werror=incompatible-pointer-types]
      .policy = wlcore_vendor_attr_policy,
                ^~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net//wireless/ti/wlcore/vendor_cmd.c:189:13: note: (near 
initialization for 'wlcore_vendor_commands[2].dumpit')
   cc1: some warnings being treated as errors

vim +169 drivers/net//wireless/ti/wlcore/vendor_cmd.c

   159  
   160  static const struct wiphy_vendor_command wlcore_vendor_commands[] = {
   161          {
   162                  .info = {
   163                          .vendor_id = TI_OUI,
   164                          .subcmd = WLCORE_VENDOR_CMD_SMART_CONFIG_START,
   165                  },
   166                  .flags = WIPHY_VENDOR_CMD_NEED_NETDEV |
   167                           WIPHY_VENDOR_CMD_NEED_RUNNING,
   168                  .doit = wlcore_vendor_cmd_smart_config_start,
 > 169                  .policy = wlcore_vendor_attr_policy,
   170          },
   171          {
   172                  .info = {
   173                          .vendor_id = TI_OUI,
   174                          .subcmd = WLCORE_VENDOR_CMD_SMART_CONFIG_STOP,
   175                  },
   176                  .flags = WIPHY_VENDOR_CMD_NEED_NETDEV |
   177                           WIPHY_VENDOR_CMD_NEED_RUNNING,
   178                  .doit = wlcore_vendor_cmd_smart_config_stop,
   179                  .policy = wlcore_vendor_attr_policy,
   180          },
   181          {
   182                  .info = {
   183                          .vendor_id = TI_OUI,
   184                          .subcmd = 
WLCORE_VENDOR_CMD_SMART_CONFIG_SET_GROUP_KEY,
   185                  },
   186                  .flags = WIPHY_VENDOR_CMD_NEED_NETDEV |
   187                           WIPHY_VENDOR_CMD_NEED_RUNNING,
   188                  .doit = wlcore_vendor_cmd_smart_config_set_group_key,
   189                  .policy = wlcore_vendor_attr_policy,
   190          },
   191  };
   192  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

Reply via email to