May be a dumb question but:

On Mon, Sep 16, 2019 at 12:03 AM <yhchu...@realtek.com> wrote:
>
> From: Yan-Hsuan Chuang <yhchu...@realtek.com>
>
> Interrupt is disabled to stop PCI, which means the skbs
> queued for each TX ring will not be released via DMA
> interrupt.

In what cases do you hit this? I think you do this when entering PS
mode, no? But then, see below.

> To avoid those skbs remained being left in
> the skb queue until PCI has been removed, driver needs
> to release skbs by itself.

Doesn't that also mean your dropping these packets? Shouldn't you be
delaying PS transitions until you've finished TX'ing?

Brian

Reply via email to