On Thu, 2019-10-03 at 23:21 -0700, Kan Yan wrote:
>
> +/* The firmware's transmit queue size limit in airtime */
> +#define IEEE80211_DEFAULT_AQL_INTERFACE_LIMIT 24000
I'm not sure I understand this completely, but IMHO rewording it to be
like a "NIC limit" would be better.
However, I'm not sure it *shouldn't* actually be per interface (i.e.
moving from
local->aql_total_pending_airtime
to
sdata->aql_total_pending_airtime
because you could have multiple channels etc. involved and then using a
single airtime limit across two interfaces that are actually on two
different channels (e.g. 2.4 and 5 GHz) doesn't make that much sense.
Actually, it does make some sense as long as the NIC is actually
channel-hopping ... but that's in the process of changing now, there's
going to be hardware really soon (or perhaps already exists) that has
real dual-band capabilities...
Maybe we can live with this now, but we'd probably expect to change this
really soon.
johannes
