On 4/1/20 8:37 PM, Bruce Ashfield wrote:
On Tue, Mar 31, 2020 at 11:07 PM Xu, Yanfei <[email protected]> wrote:
Hi Bruce,
Not a build failure, but a compile warning. when I built
v5.4/standard/xilinx-zynq kernel, It
occured the blow warning in log.do_compile.
# work-shared/xilinx-zynq/kernel-source/fs/yaffs2/yaffs_vfs.c:1829:6: warning:
unused variable 'i_version' [-Wunused-variable]
# 1829 | u64 i_version; ^~~~~~~~~
# CC fs/ubifs/replay.o
Aha. Thanks, that helps.
I squashed a bunch of those errors when updating the support, but one
must have slipped through.
Then I took a look at the previous commits about yaffs2 in
linux-yocto/v5.4/standard/base
kernel and found the yaffs2 code was been updated recently. Some defferences
about yaffs_readdir（）
in yaffs_vfs.c than before. It causes the following patch[yaffs: Fix build
failure...1fffb37acca0]
appled 'u64 i_version' at a wrong place. Maybe there is a glable i_version
variable somewhere，
hence it didn't occur a build failure.
Agreed. I'll fixup the header slightly and merge the patch.
Have you tried linux-yocto-dev ? I also had to update yaffs2 there,
and may need a similar fix.
Yep， I have tried it. Yaffs2 in linux-yocto-dev was not updated as in
linux-yocto, hence it
doesn't have the issue. However， you should pay attention to this
place，if you update
yaffs2 in linux-yocto-dev someday.
Regards，
Yanfei
Bruce
Regards,
Yanfei
On 3/31/20 11:17 PM, Bruce Ashfield wrote:
What configuration is showing this build failure ? All my 5.4 builds
come back green, with yaffs2 enabled. Do you have some different
options enabled ? I'd like to reproduce it locally.
root@qemuarm64:~# uname -a
Linux qemuarm64 5.4.28-yocto-standard #1 SMP PREEMPT Mon Mar 30
14:29:06 UTC 2020 aarch64 aarch64 aarch64 GNU/Linux
root@qemuarm64:~# zcat /proc/config.gz | grep YAFFS2
CONFIG_YAFFS_YAFFS2=y
CONFIG_YAFFS_AUTO_YAFFS2=y
root@qemuarm64:~#
Bruce
On Mon, Mar 30, 2020 at 11:09 PM <[email protected]> wrote:
From: Yanfei Xu <[email protected]>
Signed-off-by: Yanfei Xu <[email protected]>
---
fs/yaffs2/yaffs_vfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/yaffs2/yaffs_vfs.c b/fs/yaffs2/yaffs_vfs.c
index 4fbd0a42ff3d..7a951baaf043 100644
--- a/fs/yaffs2/yaffs_vfs.c
+++ b/fs/yaffs2/yaffs_vfs.c
@@ -1826,7 +1826,6 @@ static int yaffs_iterate(struct file *f, struct
dir_context *dc)
int ret_val = 0;
char name[YAFFS_MAX_NAME_LENGTH + 1];
- u64 i_version;
obj = yaffs_dentry_to_obj(Y_GET_DENTRY(f));
dev = obj->my_dev;
@@ -1900,6 +1899,7 @@ static int yaffs_readdir(struct file *f, void *dirent,
filldir_t filldir)
int ret_val = 0;
char name[YAFFS_MAX_NAME_LENGTH + 1];
+ u64 i_version;
obj = yaffs_dentry_to_obj(Y_GET_DENTRY(f));
dev = obj->my_dev;
--
2.18.2
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#8570):
https://lists.yoctoproject.org/g/linux-yocto/message/8570
Mute This Topic: https://lists.yoctoproject.org/mt/72670043/21656
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/linux-yocto/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
